]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
projects / thirdparty / Python / cpython.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: c157edb) | patch
bpo-13487: Use sys.modules.copy() in inspect.getmodule() for thread safety. (GH-18786)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Thu, 5 Mar 2020 01:03:29 +0000 (17:03 -0800)
committerNed Deily <nad@python.org>
Tue, 10 Mar 2020 05:46:59 +0000 (01:46 -0400)
commit7058d2d96c5ca4dfc6c754c5cd737c6eb2a8fd67
treef61ced2679be73cf9092c8b9d064413139630a95tree | snapshot
parentc157edb73b234409263ca0d7b6b41ad5f0b455d6commit | diff
bpo-13487: Use sys.modules.copy() in inspect.getmodule() for thread safety. (GH-18786)

`list(sys.modules.items())` was apparently not immune to "dictionary
changed size during iteration" errors.

Tested internally using an integration test that has run into this a couple of times in the past two years.  With this patch applied, the test is no longer flaky.
(cherry picked from commit 85cf1d514b84dc9a4bcb40e20a12e1d82ff19f20)

Co-authored-by: Gregory P. Smith <gps@google.com>
Lib/inspect.py diff | blob | blame | history
Misc/NEWS.d/next/Library/2020-03-04-16-10-59.bpo-13487.gqe4Fb.rst [new file with mode: 0644] blob
Mirror of https://github.com/python/cpython.git