]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
HID: hid-steam: Fix issues with disabling both gamepad mode and lizard mode
authorVicki Pfau <vi@endrift.com>
Thu, 16 Jan 2025 01:28:16 +0000 (17:28 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Mar 2025 19:54:16 +0000 (12:54 -0700)
commit705f2515189c2a00a45a5b15f81111eaaa232d95
treecc29d5ca8d78711328712ceb3d1a4a3d2af423b7
parent6ca3d4d87af406a390a34ea924ab65c517e6e132
HID: hid-steam: Fix issues with disabling both gamepad mode and lizard mode

[ Upstream commit 05c4ede6951b5d8e083b6bb237950cac59bdeb92 ]

When lizard mode is disabled, there were two issues:

1. Switching between gamepad mode and desktop mode still functioned, even
though desktop mode did not. This lead to the ability to "break" gamepad mode
by holding down the Options key even while lizard mode is disabled

2. If you were in desktop mode when lizard mode is disabled, you would
immediately enter this faulty mode.

This patch properly disables the ability to switch between gamepad mode and the
faulty desktop mode by holding the Options key, as well as effectively removing
the faulty mode by bypassing the early returns if lizard mode is disabled.

Reported-by: Eugeny Shcheglov <eugenyshcheglov@gmail.com>
Signed-off-by: Vicki Pfau <vi@endrift.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-steam.c