]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
atm: clip: Fix potential null-ptr-deref in to_atmarpd().
authorKuniyuki Iwashima <kuniyu@google.com>
Fri, 4 Jul 2025 06:23:51 +0000 (06:23 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 10 Jul 2025 00:52:26 +0000 (17:52 -0700)
commit706cc36477139c1616a9b2b96610a8bb520b7119
treef271517639cd87b2b098666eadb6010e510ddcfb
parent3c78f91e82d65d8927dc7976636bc5fae666370a
atm: clip: Fix potential null-ptr-deref in to_atmarpd().

atmarpd is protected by RTNL since commit f3a0592b37b8 ("[ATM]: clip
causes unregister hang").

However, it is not enough because to_atmarpd() is called without RTNL,
especially clip_neigh_solicit() / neigh_ops->solicit() is unsleepable.

Also, there is no RTNL dependency around atmarpd.

Let's use a private mutex and RCU to protect access to atmarpd in
to_atmarpd().

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250704062416.1613927-2-kuniyu@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/atm/clip.c