]> git.ipfire.org Git - thirdparty/linux.git/commit
wifi: mac80211: fix unassigned variable access
authorAntonio Quartulli <antonio@mandelbit.com>
Tue, 22 Jul 2025 12:06:34 +0000 (14:06 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 22 Jul 2025 12:13:03 +0000 (14:13 +0200)
commit708243c62efde8241e2c66e9c3f377658855149d
tree21bd079dbf84357cc8845282202eece4511b8ced
parent69fdb084355d6c0b353536024cc51aa5f7ffb62c
wifi: mac80211: fix unassigned variable access

In ieee80211_latest_active_link_conn_timeout() we loop over all
sta->links in order to compute the timeout expiring last across
all links.

Such timeout is stored in `latest_timeout` which is used in the
time_after() comparison before having been initialized.

Fix this behaviour by initializing the variable to `jiffies` and
adapt surrouding conditions accordingly.

Note that the caller assumed latest_timeout to be 0 if no active
link was found. This is not appropriate because jiffies=0 is a
valid (and recurrent, although not often) point in time.
By using `jiffies` as default value for latest_timeout, we can
fix the caller as well.

Address-Coverity-ID: 1647986 ("Uninitialized variables (UNINIT)")
Fixes: 1bc892d76a6f ("wifi: mac80211: extend connection monitoring for MLO")
Signed-off-by: Antonio Quartulli <antonio@mandelbit.com>
Link: https://patch.msgid.link/20250722120634.3501-1-antonio@mandelbit.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/mlme.c