]> git.ipfire.org Git - thirdparty/libvirt.git/commit
libxl: Don't free def member of virDomainObj
authorJim Fehlig <jfehlig@suse.com>
Thu, 24 Sep 2020 16:39:13 +0000 (10:39 -0600)
committerJim Fehlig <jfehlig@suse.com>
Thu, 24 Sep 2020 21:02:31 +0000 (15:02 -0600)
commit709c0e7616c56fe44dfd9bccc1df4d8506e334b7
treeee75319f6069587f1902ebca7fe65b4d815fb6b6
parent88008f3b99a17a52dff4bbef58ccd4d95b6358be
libxl: Don't free def member of virDomainObj

The refactoring in commit de49d5bad3 accidentally dropped the statement
setting def to NULL after successfully adding it to the virDomainObjList,
causing it to be freed while still in use. The resulting memory
corruption caused unpredictable behavior, often resulting in a libvirtd
crash.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Neal Gompa <ngompa13@gmail.com>
src/libxl/libxl_driver.c