]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
lockd: Plug nlm_file refcount leak on cached nlm_do_fopen() failure
authorChuck Lever <chuck.lever@oracle.com>
Thu, 14 May 2026 20:56:06 +0000 (16:56 -0400)
committerChuck Lever <cel@kernel.org>
Tue, 9 Jun 2026 20:32:59 +0000 (16:32 -0400)
commit70a38f87bed7f0694fd07988b47b2db1e10d8df3
tree3a2c5a4ade607a6b674e582adde8c235d3d6ad72
parentf16a1513452edb532fec81e591c64c320866719c
lockd: Plug nlm_file refcount leak on cached nlm_do_fopen() failure

The cached-file path in nlm_lookup_file() reaches the found: label
unconditionally, even when nlm_do_fopen() fails. At that label
*result and file->f_count are updated before the error is returned.
The wrappers nlm3svc_lookup_file() and nlm4svc_lookup_file() then
bail out of their switch without copying *result back to their
caller, so the proc handler's local nlm_file pointer remains NULL
and the cleanup path skips nlm_release_file(). The f_count
increment is never released, and nlm_traverse_files() can no
longer reap the file because its refcount never returns to zero
between requests.

Short-circuit the cached path so neither *result nor f_count is
touched when nlm_do_fopen() fails on a hashed nlm_file.

Fixes: 7f024fcd5c97 ("Keep read and write fds with each nlm_file")
Cc: stable@vger.kernel.org
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/lockd/svcsubs.c