]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: macb: avoid dealing with endianness in macb_set_hwaddr()
authorThéo Lebrun <theo.lebrun@bootlin.com>
Tue, 23 Sep 2025 16:00:27 +0000 (18:00 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 27 Sep 2025 00:54:51 +0000 (17:54 -0700)
commit70a5ce8bc94545ba0fb47b2498bfb12de2132f4d
treeb6ee4df712203aa4a5c3fe653a58ef71e30b578c
parent78d901897b3cae06b38f54e48a2378cf9da21175
net: macb: avoid dealing with endianness in macb_set_hwaddr()

bp->dev->dev_addr is of type `unsigned char *`. Casting it to a u32
pointer and dereferencing implies dealing manually with endianness,
which is error-prone.

Replace by calls to get_unaligned_le32|le16() helpers.

This was found using sparse:
   ⟩ make C=2 drivers/net/ethernet/cadence/macb_main.o
   warning: incorrect type in assignment (different base types)
      expected unsigned int [usertype] bottom
      got restricted __le32 [usertype]
   warning: incorrect type in assignment (different base types)
      expected unsigned short [usertype] top
      got restricted __le16 [usertype]
   ...

Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250923-macb-fixes-v6-5-772d655cdeb6@bootlin.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cadence/macb_main.c