]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sched/fair: Fix CFS bandwidth hrtimer expiry type
authorOdin Ugedal <odin@uged.al>
Tue, 29 Jun 2021 12:14:52 +0000 (14:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Jul 2021 07:12:34 +0000 (09:12 +0200)
commit70e95b0d4657a5b1b8e45c86bc46953c305d9ff9
tree09ddf4054448ef4839debad982708382e59252a3
parent165717ea4660a5ac5b992cf79779542b12e13aa6
sched/fair: Fix CFS bandwidth hrtimer expiry type

[ Upstream commit 72d0ad7cb5bad265adb2014dbe46c4ccb11afaba ]

The time remaining until expiry of the refresh_timer can be negative.
Casting the type to an unsigned 64-bit value will cause integer
underflow, making the runtime_refresh_within return false instead of
true. These situations are rare, but they do happen.

This does not cause user-facing issues or errors; other than
possibly unthrottling cfs_rq's using runtime from the previous period(s),
making the CFS bandwidth enforcement less strict in those (special)
situations.

Signed-off-by: Odin Ugedal <odin@uged.al>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Ben Segall <bsegall@google.com>
Link: https://lore.kernel.org/r/20210629121452.18429-1-odin@uged.al
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/sched/fair.c