]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
btrfs: scrub: reject unsupported scrub flags
authorQu Wenruo <wqu@suse.com>
Thu, 6 Apr 2023 05:00:34 +0000 (13:00 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 May 2023 14:11:34 +0000 (23:11 +0900)
commit70f12a8f88add1ac4804af9012fc3bbc5d1b180f
treeb5cd1925d3805aae427859f83071911eba2aee64
parent6d2865896d34e95c2e20e1191e79cfbe68018822
btrfs: scrub: reject unsupported scrub flags

commit 604e6681e114d05a2e384c4d1e8ef81918037ef5 upstream.

Since the introduction of scrub interface, the only flag that we support
is BTRFS_SCRUB_READONLY.  Thus there is no sanity checks, if there are
some undefined flags passed in, we just ignore them.

This is problematic if we want to introduce new scrub flags, as we have
no way to determine if such flags are supported.

Address the problem by introducing a check for the flags, and if
unsupported flags are set, return -EOPNOTSUPP to inform the user space.

This check should be backported for all supported kernels before any new
scrub flags are introduced.

CC: stable@vger.kernel.org # 4.14+
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/btrfs/ioctl.c
include/uapi/linux/btrfs.h