]> git.ipfire.org Git - thirdparty/haproxy.git/commit
projects / thirdparty / haproxy.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9cc670f) | patch
[MINOR] http-auth: last fix was wrong
authorKrzysztof Olędzki <ole@ans.pl>
Mon, 1 Feb 2010 11:36:53 +0000 (12:36 +0100)
committerWilly Tarreau <w@1wt.eu>
Mon, 1 Feb 2010 11:54:32 +0000 (12:54 +0100)
commit711ad9eb270c0f9151f94c667b7506733f5e3d65
treeb650b285b38105be91127773b451f176510476a5tree
parent9cc670f7d9b5e982cc046772c2eb080df1fb542fcommit | diff
[MINOR] http-auth: last fix was wrong

I'm not sure if the fix is correct:

- if (req_acl->cond)
-         ret = acl_exec_cond(req_acl->cond, px, s, txn, ACL_DIR_REQ);
+ if (!req_acl->cond)
+         continue;

Doesn't it ignore rules with no condition attached? I think that the
proper solution would be the following.
src/proto_http.c diff | blob | blame | history
Mirror of https://github.com/haproxy/haproxy.git