]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Don't call CheckAttributeType() with InvalidOid on dropped cols
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 23 Apr 2026 18:05:27 +0000 (21:05 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 23 Apr 2026 18:28:26 +0000 (21:28 +0300)
commit713bce9484dea8bce93ec7abacd0e47ddf30dcf5
tree1d2290abcdc087a940d0ab65f112708cf6c2bc77
parentdd4069197650d5c6d1d6385ceccc43ae2ccffc67
Don't call CheckAttributeType() with InvalidOid on dropped cols

If CheckAttributeType() is called with InvalidOid, it performs a bunch
of pointless, futile syscache lookups with InvalidOid, but ultimately
tolerates it and has no effect. We were calling it with InvalidOid on
dropped columns, but it seems accidental that it works, so let's stop
doing it.

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/93ce56cd-02a6-4db1-8224-c8999372facc@iki.fi
Backpatch-through: 14
src/backend/catalog/heap.c