]> git.ipfire.org Git - thirdparty/libvirt.git/commit
virDomainSnapshotRedefinePrep: Don't do partial redefine
authorPeter Krempa <pkrempa@redhat.com>
Wed, 12 Jan 2022 16:00:22 +0000 (17:00 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 14 Jan 2022 17:11:58 +0000 (18:11 +0100)
commit717f1cc4d116b864c22908f6510dbce445b5f5eb
tree7843753bbc9282b649cee0b7d33941e7932aa728
parentd281c1323f55b0a188f235f67a3fc4b16c9fc1cd
virDomainSnapshotRedefinePrep: Don't do partial redefine

'virDomainSnapshotRedefinePrep' does everything needed for a redefine
when the snapshot exists but not when we are defining metadata for a new
snapshot. This gives us weird semantics.

Extract the code for replacing the definition of an existing snapshot
into a new helper 'virDomainSnapshotReplaceDef' and refactor all
callers.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/conf/snapshot_conf.c
src/conf/snapshot_conf.h
src/conf/virdomainsnapshotobjlist.c
src/conf/virdomainsnapshotobjlist.h
src/libvirt_private.syms
src/qemu/qemu_snapshot.c
src/test/test_driver.c