]> git.ipfire.org Git - thirdparty/linux.git/commit
cpufreq: mediatek-hw: don't use error path on NULL fdvfs
authorNicolas Frattaroli <nicolas.frattaroli@collabora.com>
Tue, 19 Aug 2025 11:21:42 +0000 (13:21 +0200)
committerViresh Kumar <viresh.kumar@linaro.org>
Wed, 20 Aug 2025 04:06:58 +0000 (09:36 +0530)
commit72907ea795e0bf261def10595d19ded441b90d9f
treefbea451056d1be6cadf6c6271b8ddaeb5e47fb1e
parentcd5d4621ba846dad9b2e6b0c2d1518d083fcfa13
cpufreq: mediatek-hw: don't use error path on NULL fdvfs

The IS_ERR_OR_NULL check for priv->fdvfs is inappropriate, and should be
an IS_ERR check instead, as a NULL value here would propagate it to
PTR_ERR.

In practice, there is no problem here, as devm_of_iomap cannot return
NULL in any circumstance. However, it causes a Smatch static checker
warning.

Fix the warning by changing the check from IS_ERR_OR_NULL to IS_ERR.

Fixes: 32e0d669f3ac ("cpufreq: mediatek-hw: Add support for MT8196")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-pm/aKQubSEXH1TXQpnR@stanley.mountain/
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/mediatek-cpufreq-hw.c