]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Revert "conf: clean up memory containing secrets before freeing"
authorPeter Krempa <pkrempa@redhat.com>
Wed, 7 Sep 2022 11:09:13 +0000 (13:09 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 7 Sep 2022 13:54:09 +0000 (15:54 +0200)
commit72cf345bc2de97a5f60f97a09926b9673ea46704
treecf3bd4162f8c06db34ab2d8e19bce6aebcb164d7
parentecc742126a521d21d94e1fd7c71f39172834267a
Revert "conf: clean up memory containing secrets before freeing"

Adding supposedly secure cleanup for secrets in anything related to the
XML parser is pointless because there are multiple other un-sanitized
copies of the full XML and the XML parser state at the very least.

Similarly in case RPC was used to transport the XML the RPC buffers are
not sanitized.

Additionally this patch was incomplete as it didn't sanitize the
password in the cleanup function for virDomainGraphicsAuthDef.

This reverts commit 51f8130d78fde3201b49c02b7095ff918b6e658a

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/conf/domain_conf.c