]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/amd/amdgpu/amdgpu_cs: fix refcount leak of a dma_fence obj
authorXin Xiong <xiongx18@fudan.edu.cn>
Fri, 21 Jan 2022 20:46:23 +0000 (15:46 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Apr 2022 12:15:00 +0000 (14:15 +0200)
commit72d77ddb2224ebc00648f4f78f8a9a259dccbdf7
treefa450398ff87b9e1354642db6c36dbd3b1f9758c
parent25efc5d03455c3839249bc77fce5e29ecb54677e
drm/amd/amdgpu/amdgpu_cs: fix refcount leak of a dma_fence obj

[ Upstream commit dfced44f122c500004a48ecc8db516bb6a295a1b ]

This issue takes place in an error path in
amdgpu_cs_fence_to_handle_ioctl(). When `info->in.what` falls into
default case, the function simply returns -EINVAL, forgetting to
decrement the reference count of a dma_fence obj, which is bumped
earlier by amdgpu_cs_get_fence(). This may result in reference count
leaks.

Fix it by decreasing the refcount of specific object before returning
the error code.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c