]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
dmaengine: zynqmp_dma: Add shutdown operation support
authorAbin Joseph <abin.joseph@amd.com>
Tue, 22 Jul 2025 07:02:55 +0000 (12:32 +0530)
committerVinod Koul <vkoul@kernel.org>
Wed, 20 Aug 2025 17:27:20 +0000 (22:57 +0530)
commit72dd8b2914b5db1dccf902971c2ea6b541711b28
tree4920f06f0d11875e6e81c9eab4d52d8685c2b6b9
parent8f5ae30d69d7543eee0d70083daf4de8fe15d585
dmaengine: zynqmp_dma: Add shutdown operation support

Add shutdown callback to ensure that DMA operations are properly stopped
and resources are released during system shutdown or kexec operations.
Fix incorrect PM state handling in the remove function that was causing
clock disable warnings during the shutdown operations, which was not
implemented earlier. The original logic used pm_runtime_enabled() check
after calling the pm_runtime_disable(), would always evaluate to true
after the disable call, which leads to unconditionally calling the
runtime_suspend regardless of the device's actual power state.

During shutdown, the device may already be suspended with clock disabled
from the autosuspend timer, causing the clock framework to warn about
the double-disable attempt. The pm_runtime_active() function checks the
actual device power state rather than the PM subsystem's enabled/disabled
status. ensuring the runtime_suspend is only called when the device is in
active power state. This prevents clock warnings during shutdown while
maintaining proper cleanup during normal remove operations.

Signed-off-by: Abin Joseph <abin.joseph@amd.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Link: https://lore.kernel.org/r/20250722070255.28944-1-abin.joseph@amd.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/xilinx/zynqmp_dma.c