]> git.ipfire.org Git - thirdparty/linux.git/commit
PCI: sky1: Fix missing cleanup of ECAM config on probe failure
authorFelix Gu <ustc.gu@gmail.com>
Mon, 23 Mar 2026 16:41:28 +0000 (00:41 +0800)
committerManivannan Sadhasivam <mani@kernel.org>
Tue, 24 Mar 2026 07:18:54 +0000 (12:48 +0530)
commit72e76b63d6ff6d1f96acccbfc6c118656f63e66a
treeeaf24d2d7f9a33467a9861662f3ce91909461656
parent6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
PCI: sky1: Fix missing cleanup of ECAM config on probe failure

When devm_kzalloc() for reg_off fails, the code returns -ENOMEM without
freeing pcie->cfg, which was allocated earlier by pci_ecam_create().

Add the missing pci_ecam_free() call to properly release the allocated ECAM
configuration window on this error path.

Fixes: a0d9f2c08f45 ("PCI: sky1: Add PCIe host support for CIX Sky1")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Hans Zhang <18255117159@163.com>
Link: https://patch.msgid.link/20260324-sky1-v1-1-6a00cb2776b6@gmail.com
drivers/pci/controller/cadence/pci-sky1.c