]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
EDAC/i5400: Fix snprintf() limit calculation in calculate_dimm_size()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 9 Dec 2025 14:37:04 +0000 (17:37 +0300)
committerTony Luck <tony.luck@intel.com>
Wed, 17 Dec 2025 18:00:20 +0000 (10:00 -0800)
commit72f12683611344853ab030fe7d19b23970ed2bd8
treeb2b3104b6b1030f8f41bb339f1cd1cb6bcdc5b6f
parent7b5c7e83ac405ff9ecbdd92b37a477f4288f8814
EDAC/i5400: Fix snprintf() limit calculation in calculate_dimm_size()

The snprintf() can't really overflow because we're writing a max of 42
bytes to a PAGE_SIZE buffer.  But my static checker complains because
the limit calculation doesn't take the first 11 space characters that
we wrote into the buffer into consideration.  Fix this for the sake of
correctness even though it doesn't affect runtime.

Also delete an earlier "space -= n;" which was not used.

Fixes: 68d086f89b80 ("i5400_edac: improve debug messages to better represent the filled memory")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Link: https://patch.msgid.link/ccd06b91748e7ed8e33eeb2ff1e7b98700879304.1765290801.git.dan.carpenter@linaro.org
drivers/edac/i5400_edac.c