]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Fix system pages handling in <memoryBacking/>
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 7 Jan 2015 14:17:03 +0000 (15:17 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 7 Jan 2015 17:32:07 +0000 (18:32 +0100)
commit732586d979738077af7e8b7dfd11d61fe46533c6
tree49c247301bd671a9f8d716ecdd766af4cfd8bf48
parent3a3b3691d145418dc6616e7ce8a5ca8ba857bc5b
qemu: Fix system pages handling in <memoryBacking/>

In one of my previous commits (311b4a67) I've tried to allow to
pass regular system pages to <hugepages>. However, there was a
little bug that wasn't caught. If domain has guest NUMA topology
defined, qemuBuildNumaArgStr() function takes care of generating
corresponding command line. The hugepages backing for guest NUMA
nodes is handled there too. And here comes the bug: the hugepages
setting from XML is stored in KiB internally, however, the system
pages size was queried and stored in Bytes. So the check whether
these two are equal was failing even if it shouldn't.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_command.c