]> git.ipfire.org Git - thirdparty/linux.git/commit
counter: interrupt-cnt: Protect enable/disable OPs with mutex
authorAlexander Sverdlin <alexander.sverdlin@siemens.com>
Mon, 31 Mar 2025 16:36:40 +0000 (18:36 +0200)
committerWilliam Breathitt Gray <wbg@kernel.org>
Fri, 2 May 2025 23:45:11 +0000 (08:45 +0900)
commit7351312632e831e51383f48957d47712fae791ef
treec3b4418c12591b387d792e645c87a6d3bdbf65d8
parentb4432656b36e5cc1d50a1f2dc15357543add530e
counter: interrupt-cnt: Protect enable/disable OPs with mutex

Enable/disable seems to be racy on SMP, consider the following scenario:

CPU0 CPU1

interrupt_cnt_enable_write(true)
{
if (priv->enabled == enable)
return 0;

if (enable) {
priv->enabled = true;
interrupt_cnt_enable_write(false)
{
if (priv->enabled == enable)
return 0;

if (enable) {
priv->enabled = true;
enable_irq(priv->irq);
} else {
disable_irq(priv->irq)
priv->enabled = false;
}
enable_irq(priv->irq);
} else {
disable_irq(priv->irq);
priv->enabled = false;
}

The above would result in priv->enabled == false, but IRQ left enabled.
Protect both write (above race) and read (to propagate the value on SMP)
callbacks with a mutex.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Fixes: a55ebd47f21f ("counter: add IRQ or GPIO based counter")
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://lore.kernel.org/r/20250331163642.2382651-1-alexander.sverdlin@siemens.com
Signed-off-by: William Breathitt Gray <wbg@kernel.org>
drivers/counter/interrupt-cnt.c