]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
can: gs_usb: gs_usb_receive_bulk_callback(): fix URB memory leak
authorMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 23 Dec 2025 20:21:39 +0000 (21:21 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 9 Jan 2026 09:31:21 +0000 (10:31 +0100)
commit7352e1d5932a0e777e39fa4b619801191f57e603
tree1b994b3b2bad1229d14a82a9471b0b0c1a9317d3
parentb1979778e98569c1e78c2c7f16bb24d76541ab00
can: gs_usb: gs_usb_receive_bulk_callback(): fix URB memory leak

In gs_can_open(), the URBs for USB-in transfers are allocated, added to the
parent->rx_submitted anchor and submitted. In the complete callback
gs_usb_receive_bulk_callback(), the URB is processed and resubmitted. In
gs_can_close() the URBs are freed by calling
usb_kill_anchored_urbs(parent->rx_submitted).

However, this does not take into account that the USB framework unanchors
the URB before the complete function is called. This means that once an
in-URB has been completed, it is no longer anchored and is ultimately not
released in gs_can_close().

Fix the memory leak by anchoring the URB in the
gs_usb_receive_bulk_callback() to the parent->rx_submitted anchor.

Fixes: d08e973a77d1 ("can: gs_usb: Added support for the GS_USB CAN devices")
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20260105-gs_usb-fix-memory-leak-v2-1-cc6ed6438034@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/gs_usb.c