]> git.ipfire.org Git - thirdparty/linux.git/commit
net: ethtool: fix missing closing paren in rings_reply_size()
authorTao Cui <cuitao@kylinos.cn>
Fri, 8 May 2026 12:54:12 +0000 (20:54 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 12 May 2026 01:42:25 +0000 (18:42 -0700)
commit73d587ae684d176fac9db94173f77d78a794ea4f
tree846f7471b5640bbd588c0830e4964c53851af791
parent89cc3ffe5d6456e17811beab143f19bf08b9a15e
net: ethtool: fix missing closing paren in rings_reply_size()

sizeof(u32) on the _RINGS_CQE_SIZE line is missing its closing
parenthesis, causing nla_total_size() to absorb the subsequent
_TX_PUSH and _RX_PUSH entries.

The resulting size estimate happens to be numerically identical
due to NLA alignment, so not treating this as a real fix.
But the nesting is wrong and misleading.

Signed-off-by: Tao Cui <cuitao@kylinos.cn>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Reviewed-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20260508125412.189804-1-cuitao@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/rings.c