]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Make column-level collation quoting dialect-specific
authorMike Bayer <mike_mp@zzzcomputing.com>
Wed, 10 Jan 2018 03:17:59 +0000 (22:17 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Fri, 12 Jan 2018 18:01:26 +0000 (13:01 -0500)
commit7402987fd218c42ed2a909a5031186d2b702bb88
treea418897eb557bbdad09878aa7dcc2e2aab7dfb3a
parent127ead7452f326509cde38fcf7c9f38f69d9ae0a
Make column-level collation quoting dialect-specific

Fixed regression in 1.2 where newly repaired quoting
of collation names in :ticket:`3785` breaks SQL Server,
which explicitly does not understand a quoted collation
name.   Whether or not mixed-case collation names are
quoted or not is now deferred down to a dialect-level
decision so that each dialect can prepare these identifiers
directly.

Change-Id: Iaf0a8123d9bf4711219e320896bb28c5d2649304
Fixes: #4154
doc/build/changelog/unreleased_12/4154.rst [new file with mode: 0644]
lib/sqlalchemy/dialects/mssql/base.py
lib/sqlalchemy/sql/compiler.py
lib/sqlalchemy/sql/elements.py
lib/sqlalchemy/testing/requirements.py
lib/sqlalchemy/testing/suite/test_select.py
test/dialect/mssql/test_compiler.py
test/requirements.py
test/sql/test_compiler.py
test/sql/test_quote.py