]> git.ipfire.org Git - thirdparty/git.git/commit
sideband: introduce an "escape hatch" to allow control characters
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Wed, 17 Dec 2025 14:23:40 +0000 (14:23 +0000)
committerJunio C Hamano <gitster@pobox.com>
Thu, 18 Dec 2025 01:58:07 +0000 (10:58 +0900)
commit740dce52b66417f8240abdc155c45da8bd2af2dc
tree918fd941e5887c0a5cc70110b4a6a231092b3d29
parenta7afa7a1dd73f26b5578c81b14112e36dc55eb3a
sideband: introduce an "escape hatch" to allow control characters

The preceding commit fixed the vulnerability whereas sideband messages
(that are under the control of the remote server) could contain ANSI
escape sequences that would be sent to the terminal verbatim.

However, this fix may not be desirable under all circumstances, e.g.
when remote servers deliberately add coloring to their messages to
increase their urgency.

To help with those use cases, give users a way to opt-out of the
protections: `sideband.allowControlCharacters`.

Suggested-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Documentation/config.txt
Documentation/config/sideband.txt [new file with mode: 0644]
sideband.c
t/t5409-colorize-remote-messages.sh