]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ext4: add missing brelse() in add_new_gdb_meta_bg()
authorLukas Czerner <lczerner@redhat.com>
Fri, 15 Mar 2019 04:15:32 +0000 (00:15 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 13 Aug 2019 11:38:41 +0000 (12:38 +0100)
commit742015130eee098b966e1f5b2a4b3f8395089d53
tree085a50f61fb6646f1a5b9dd29467410a74061968
parent3668fd2619fed84326bc449a79ee4ad9e270f229
ext4: add missing brelse() in add_new_gdb_meta_bg()

commit d64264d6218e6892edd832dc3a5a5857c2856c53 upstream.

Currently in add_new_gdb_meta_bg() there is a missing brelse of gdb_bh
in case ext4_journal_get_write_access() fails.
Additionally kvfree() is missing in the same error path. Fix it by
moving the ext4_journal_get_write_access() before the ext4 sb update as
Ted suggested and release n_group_desc and gdb_bh in case it fails.

Fixes: 61a9c11e5e7a ("ext4: add missing brelse() add_new_gdb_meta_bg()'s error path")
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/ext4/resize.c