]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
phy: rockchip-snps-pcie3: fix clearing PHP_GRF_PCIESEL_CON bits
authorSebastian Reichel <sebastian.reichel@collabora.com>
Thu, 4 Apr 2024 17:11:27 +0000 (19:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 May 2024 14:32:48 +0000 (16:32 +0200)
commit743cf2f19d96c2ca4cefd4fadd5a31b3681d56ac
treef4fcddc58f437e9e30016fb762b5a1ff9f6a0f38
parentd3d3723d70c1a07872d6235162b140496937d689
phy: rockchip-snps-pcie3: fix clearing PHP_GRF_PCIESEL_CON bits

[ Upstream commit 55491a5fa163bf15158f34f3650b3985f25622b9 ]

Currently the PCIe v3 PHY driver only sets the pcie1ln_sel bits, but
does not clear them because of an incorrect write mask. This fixes up
the issue by using a newly introduced constant for the write mask.

While at it also introduces a proper GENMASK based constant for the
PCIE30_PHY_MODE.

Fixes: 2e9bffc4f713 ("phy: rockchip: Support PCIe v3")
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240404-rk3588-pcie-bifurcation-fixes-v1-2-9907136eeafd@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/phy/rockchip/phy-rockchip-snps-pcie3.c