]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MINOR: ssl: fix smp_fetch_ssl_fc_session_id
authorWilly Tarreau <w@1wt.eu>
Wed, 17 Jun 2015 16:34:14 +0000 (18:34 +0200)
committerWilly Tarreau <w@1wt.eu>
Wed, 17 Jun 2015 17:46:14 +0000 (19:46 +0200)
commit745d4127582a8c66e2e8ce35f746a78e867960af
treed9795de6615a067c8a815557f9e7d8b8c7c05989
parentad90f0d1aa6a19560a4c6bfcf5a0c18674b70417
BUG/MINOR: ssl: fix smp_fetch_ssl_fc_session_id

Dmitry Sivachenko reported the following build warning using Clang
which is a real bug :

src/ssl_sock.c:4104:44: warning: address of 'smp->data.str.len' will always
      evaluate to 'true' [-Wpointer-bool-conversion]
        if (!smp->data.str.str || !&smp->data.str.len)

The impact is very low however, it will return an empty session_id
instead of no session id when none is found.

The fix should be backported to 1.5.
src/ssl_sock.c