]> git.ipfire.org Git - thirdparty/glibc.git/commit
posix: Fix pidfd_spawn/pidfd_spawnp leak if execve fails (BZ 31695)
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>
Mon, 6 May 2024 16:20:56 +0000 (13:20 -0300)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Tue, 25 Jun 2024 16:51:16 +0000 (13:51 -0300)
commit74630b1bb717fb98f4692261f2be8d5c84851fa3
tree17d802a9463f46ea3c00b44d2c29cc7f2fbd0776
parent7f9f25f255ee2c00178779fbce502f4b94b848b9
posix: Fix pidfd_spawn/pidfd_spawnp leak if execve fails (BZ 31695)

If the pidfd_spawn/pidfd_spawnp helper process succeeds, but evecve
fails for some reason (either with an invalid/non-existent, memory
allocation, etc.) the resulting pidfd is never closed, nor returned
to caller (so it can call close).

Since the process creation failed, it should be up to posix_spawn to
also, close the file descriptor in this case (similar to what it
does to reap the process).

This patch also changes the waitpid with waitid (P_PIDFD) for pidfd
case, to avoid a possible pid re-use.

Checked on x86_64-linux-gnu.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
(cherry picked from commit c90cfce849d010474e8cccf3e5bff49a2c8b141f)
NEWS
posix/tst-spawn2.c
sysdeps/unix/sysv/linux/spawni.c