]> git.ipfire.org Git - thirdparty/automake.git/commit
Consistently use ‘our’ instead of ‘use vars’.
authorZack Weinberg <zackw@panix.com>
Fri, 11 Sep 2020 22:03:19 +0000 (18:03 -0400)
committerZack Weinberg <zackw@panix.com>
Sat, 12 Sep 2020 13:33:42 +0000 (09:33 -0400)
commit74673d1cbd3c789b26839f0c1a88ca032d47d058
tree77dbece37260727efe9f65030e0cfc478022e6cc
parent9ae8a896cb83e6693413d80b5c85e527f3bb11f6
Consistently use ‘our’ instead of ‘use vars’.

At file scope of a file containing at most one ‘package’ declaration,
‘use vars’ is exactly equivalent to ‘our’, and the latter is preferred
starting with Perl 5.6.0, which happens to be the oldest version we
support.

(This change has nothing to do with the previous two, but I want to make the
same change in Autoconf and that means doing it here for all the files synced
from Automake.)

(I don’t know why, but this change exposed a latent bug in FileUtils.pm where
the last pod block in the file didn’t have a ‘=cut’ delimiter, so the code
after it was considered documentation, causing ‘require FileUtils’ to fail.)

* lib/Automake/ChannelDefs.pm
* lib/Automake/Channels.pm
* lib/Automake/Condition.pm
* lib/Automake/Configure_ac.pm
* lib/Automake/DisjConditions.pm
* lib/Automake/FileUtils.pm
* lib/Automake/General.pm
* lib/Automake/Getopt.pm
* lib/Automake/Options.pm
* lib/Automake/Rule.pm
* lib/Automake/RuleDef.pm
* lib/Automake/VarDef.pm
* lib/Automake/Variable.pm
* lib/Automake/Wrap.pm
* lib/Automake/XFile.pm:
  Replace all uses of ‘use vars’ with ‘our’.

* lib/Automake/FileUtils.pm:
  Add missing ‘=cut’ to a pod block near the end of the file.
15 files changed:
lib/Automake/ChannelDefs.pm
lib/Automake/Channels.pm
lib/Automake/Condition.pm
lib/Automake/Configure_ac.pm
lib/Automake/DisjConditions.pm
lib/Automake/FileUtils.pm
lib/Automake/General.pm
lib/Automake/Getopt.pm
lib/Automake/Options.pm
lib/Automake/Rule.pm
lib/Automake/RuleDef.pm
lib/Automake/VarDef.pm
lib/Automake/Variable.pm
lib/Automake/Wrap.pm
lib/Automake/XFile.pm