]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
rust: use `#[used(compiler)]` to fix build and `modpost` with Rust >= 1.89.0
authorMiguel Ojeda <ojeda@kernel.org>
Sat, 12 Jul 2025 16:01:03 +0000 (18:01 +0200)
committerMiguel Ojeda <ojeda@kernel.org>
Mon, 14 Jul 2025 21:30:44 +0000 (23:30 +0200)
commit7498159226772d66f150dd406be462d75964a366
tree1fee54f46a243eac7a73daf3afaa9fe7541a35d0
parentaa7b65c2a29e8b07057b13624102c6810597c0d5
rust: use `#[used(compiler)]` to fix build and `modpost` with Rust >= 1.89.0

Starting with Rust 1.89.0 (expected 2025-08-07), the Rust compiler fails
to build the `rusttest` target due to undefined references such as:

    kernel...-cgu.0:(.text....+0x116): undefined reference to
    `rust_helper_kunit_get_current_test'

Moreover, tooling like `modpost` gets confused:

    WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/nova/nova.o
    ERROR: modpost: missing MODULE_LICENSE() in drivers/gpu/nova-core/nova_core.o

The reason behind both issues is that the Rust compiler will now [1]
treat `#[used]` as `#[used(linker)]` instead of `#[used(compiler)]`
for our targets. This means that the retain section flag (`R`,
`SHF_GNU_RETAIN`) will be used and that they will be marked as `unique`
too, with different IDs. In turn, that means we end up with undefined
references that did not get discarded in `rusttest` and that multiple
`.modinfo` sections are generated, which confuse tooling like `modpost`
because they only expect one.

Thus start using `#[used(compiler)]` to keep the previous behavior
and to be explicit about what we want. Sadly, it is an unstable feature
(`used_with_arg`) [2] -- we will talk to upstream Rust about it. The good
news is that it has been available for a long time (Rust >= 1.60) [3].

The changes should also be fine for previous Rust versions, since they
behave the same way as before [4].

Alternatively, we could use `#[no_mangle]` or `#[export_name = ...]`
since those still behave like `#[used(compiler)]`, but of course it is
not really what we want to express, and it requires other changes to
avoid symbol conflicts.

Cc: David Wood <david@davidtw.co>
Cc: Wesley Wiser <wwiser@gmail.com>
Cc: stable@vger.kernel.org # Needed in 6.12.y and later (Rust is pinned in older LTSs).
Link: https://github.com/rust-lang/rust/pull/140872
Link: https://github.com/rust-lang/rust/issues/93798
Link: https://github.com/rust-lang/rust/pull/91504
Link: https://godbolt.org/z/sxzWTMfzW
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Acked-by: Björn Roy Baron <bjorn3_gh@protonmail.com>
Link: https://lore.kernel.org/r/20250712160103.1244945-3-ojeda@kernel.org
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
rust/Makefile
rust/kernel/firmware.rs
rust/kernel/kunit.rs
rust/kernel/lib.rs
rust/macros/module.rs
scripts/Makefile.build