]> git.ipfire.org Git - thirdparty/git.git/commit
clone: fix memory leak in wanted_peer_refs()
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Fri, 1 Jul 2022 10:42:51 +0000 (12:42 +0200)
committerJunio C Hamano <gitster@pobox.com>
Fri, 1 Jul 2022 18:43:42 +0000 (11:43 -0700)
commit74a06a9f2103332d50ddc17dcd6a0a153a5e377d
treef16789bbe0f1cae2c1770d4fc7a651f7b83bdf1d
parent99b6c45d8f846ed055ba814d985084733d36dabc
clone: fix memory leak in wanted_peer_refs()

Fix a memory leak added in 0ec4b1650cc (clone: fix ref selection in
--single-branch --branch=xxx, 2012-06-22).

Whether we get our "remote_head" from copy_ref() directly, or with a
call to guess_remote_head() it'll be the result of a copy_ref() in
either case, as guess_remote_head() is a wrapper for copy_ref() (or it
returns NULL).

We can't mark any tests passing passing with SANITIZE=leak using
"TEST_PASSES_SANITIZE_LEAK=true" as a result of this change, but
e.g. "t/t1500-rev-parse.sh" now gets closer to passing.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/clone.c