]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
of/address: Fix of_node memory leak in of_dma_is_coherent
authorEvan Nimmo <evan.nimmo@alliedtelesis.co.nz>
Tue, 10 Nov 2020 02:28:25 +0000 (15:28 +1300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Nov 2020 18:22:20 +0000 (19:22 +0100)
commit74c441a02ac63f4fa2b8ef1e2d292cd083bd86ae
tree4aea3760ccbfbea5d4bb14bf94633ee630902fc2
parent16ac78d9dcffacb2e559ff5a1541c9768a93413f
of/address: Fix of_node memory leak in of_dma_is_coherent

[ Upstream commit a5bea04fcc0b3c0aec71ee1fd58fd4ff7ee36177 ]

Commit dabf6b36b83a ("of: Add OF_DMA_DEFAULT_COHERENT & select it on
powerpc") added a check to of_dma_is_coherent which returns early
if OF_DMA_DEFAULT_COHERENT is enabled. This results in the of_node_put()
being skipped causing a memory leak. Moved the of_node_get() below this
check so we now we only get the node if OF_DMA_DEFAULT_COHERENT is not
enabled.

Fixes: dabf6b36b83a ("of: Add OF_DMA_DEFAULT_COHERENT & select it on powerpc")
Signed-off-by: Evan Nimmo <evan.nimmo@alliedtelesis.co.nz>
Link: https://lore.kernel.org/r/20201110022825.30895-1-evan.nimmo@alliedtelesis.co.nz
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/of/address.c