]> git.ipfire.org Git - thirdparty/git.git/commit
bisect: handle NULL commit in `bisect_successful()`
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Fri, 10 Jul 2026 11:39:30 +0000 (11:39 +0000)
committerJunio C Hamano <gitster@pobox.com>
Fri, 10 Jul 2026 15:13:54 +0000 (08:13 -0700)
commit74fb18824cda5f28811e5d5e4653434f01238133
treee1047fb4adc7e1c5c9ed9b23d799d0c7bc409fb6
parent775f1f2b19e1c3d133356170373fedeb363988a3
bisect: handle NULL commit in `bisect_successful()`

When `lookup_commit_reference_by_name()` is called to find the first bad
commit, the result is passed to `repo_format_commit_message()`
immediately, which dereferences commit without checking for NULL.

However, the commit could be NULL, even though in practice this is
unlikely because `bisect_successful()` is only called after a successful
bisect run has identified the bad commit, but the ref could still become
dangling due to a concurrent gc or repository corruption.

Pointed out by Coverity.

Assisted-by: Claude Opus 4.6
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/bisect.c