]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tcm_qla2xxx: Fix incorrect use of __transport_register_session
authorBart Van Assche <bart.vanassche@sandisk.com>
Fri, 20 Mar 2015 05:25:16 +0000 (22:25 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Apr 2015 12:03:49 +0000 (14:03 +0200)
commit74fbe5657a8619d2a8fe4858ff8acf2fd788fa65
tree560aecfdeda161c1421c06b00ffb99c2fb25abe8
parent4a27f58b25f1ba886c2564fb7533ba5a36c10d15
tcm_qla2xxx: Fix incorrect use of __transport_register_session

commit 75c3d0bf9caebb502e96683b2bc37f9692437e68 upstream.

This patch fixes the incorrect use of __transport_register_session()
in tcm_qla2xxx_check_initiator_node_acl() code, that does not perform
explicit se_tpg->session_lock when accessing se_tpg->tpg_sess_list
to add new se_sess nodes.

Given that tcm_qla2xxx_check_initiator_node_acl() is not called with
qla_hw->hardware_lock held for all accesses of ->tpg_sess_list, the
code should be using transport_register_session() instead.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Giridhar Malavali <giridhar.malavali@qlogic.com>
Cc: Quinn Tran <quinn.tran@qlogic.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/qla2xxx/tcm_qla2xxx.c