]> git.ipfire.org Git - thirdparty/linux.git/commit
nfs_localio: duplicate nfs_close_local_fh()
authorNeilBrown <neil@brown.name>
Fri, 9 May 2025 00:46:41 +0000 (10:46 +1000)
committerAnna Schumaker <anna.schumaker@oracle.com>
Wed, 28 May 2025 21:17:14 +0000 (17:17 -0400)
commit74fc55ab2a6a0c71628fcf3b9783aae7119b5199
tree78d6858ac83f06aeff0c4d34b01eece3792fa2e2
parente6f7e1487ab528a6c653bd0d42812ff2942846cd
nfs_localio: duplicate nfs_close_local_fh()

nfs_close_local_fh() is called from two different places for quite
different use case.

It is called from nfs_uuid_put() when the nfs_uuid is being detached -
possibly because the nfs server is not longer serving that filesystem.
In this case there will always be an nfs_uuid and so rcu_read_lock() is
not needed.

It is also called when the nfs_file_localio is no longer needed.  In
this case there may not be an active nfs_uuid.

These two can race, and handling the race properly while avoiding
excessive locking will require different handling on each side.

This patch prepares the way by opencoding nfs_close_local_fh() into
nfs_uuid_put(), then simplifying the code there as befits the context.

Fixes: 86e00412254a ("nfs: cache all open LOCALIO nfsd_file(s) in client")
Signed-off-by: NeilBrown <neil@brown.name>
Signed-off-by: Anna Schumaker <anna.schumaker@oracle.com>
fs/nfs_common/nfslocalio.c