]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
uio: fix a sleep-in-atomic-context bug in uio_dmem_genirq_irqcontrol()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 18 Dec 2019 09:44:05 +0000 (17:44 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Feb 2020 07:36:27 +0000 (08:36 +0100)
commit750a95d63746458e86c6d92dfad48a05c64d0ecd
tree600b2eae87c1995e2b909602a24c68b115884926
parentb2f28d11f2a1aeb8944ff649b23b61cea3f5a689
uio: fix a sleep-in-atomic-context bug in uio_dmem_genirq_irqcontrol()

[ Upstream commit b74351287d4bd90636c3f48bc188c2f53824c2d4 ]

The driver may sleep while holding a spinlock.
The function call path (from bottom to top) in Linux 4.19 is:

kernel/irq/manage.c, 523:
synchronize_irq in disable_irq
drivers/uio/uio_dmem_genirq.c, 140:
disable_irq in uio_dmem_genirq_irqcontrol
drivers/uio/uio_dmem_genirq.c, 134:
_raw_spin_lock_irqsave in uio_dmem_genirq_irqcontrol

synchronize_irq() can sleep at runtime.

To fix this bug, disable_irq() is called without holding the spinlock.

This bug is found by a static analysis tool STCheck written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Link: https://lore.kernel.org/r/20191218094405.6009-1-baijiaju1990@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/uio/uio_dmem_genirq.c