]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
platform: arm64: thinkpad-t14s-ec: sleep after EC access
authorSebastian Reichel <sre@kernel.org>
Wed, 19 Nov 2025 00:41:41 +0000 (01:41 +0100)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fri, 21 Nov 2025 17:05:27 +0000 (19:05 +0200)
commit752630cb8c62abca0407f96cc7baa2e13335cd15
treeafa0ce373652e7a13e6a33f91562c7e76bef26ec
parent29be646f75c4406bdd8322572a6054ebd22bf63b
platform: arm64: thinkpad-t14s-ec: sleep after EC access

The ACPI ECRD and ECWR functions have a 10ms sleep at the end. It turns
out, that this is sometimes needed to avoid I2C transmission failures,
especially for functions doing regmap_update_bits (and thus read + write
shortly after each other). This fixes problems like the following
appearing in the kernel log:

leds platform::micmute: Setting an LED's brightness failed (-6)
leds platform::kbd_backlight: Setting an LED's brightness failed (-6)

The ACPI QEVT function used to read the interrupt status register also
has a 10ms sleep at the end. Without that there are problems with
reading multiple events following directly after each other resulting
in the following error message being logged:

thinkpad-t14s-ec 4-0028: Failed to read event

Fixes: 60b7ab6ce030 ("platform: arm64: thinkpad-t14s-ec: new driver")
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Link: https://patch.msgid.link/20251119-thinkpad-t14s-ec-improvements-v2-2-441219857c02@kernel.org
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/arm64/lenovo-thinkpad-t14s.c