]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netfilter: nf_conncount: garbage collection is not skipped when jiffies wrap around
authorNicklas Bo Jensen <njensen@akamai.com>
Thu, 27 Feb 2025 13:32:34 +0000 (13:32 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jan 2026 12:09:40 +0000 (13:09 +0100)
commit754512b096b92d9cf4186c65b1da9e9dd102c2e7
treece22c884e2e2260f3e23e7eb6613fa05f7be69c1
parent460fd9a9e820d93444f8a52fb195f17386626634
netfilter: nf_conncount: garbage collection is not skipped when jiffies wrap around

commit df08c94baafb001de6cf44bb7098bb557f36c335 upstream.

nf_conncount is supposed to skip garbage collection if it has already
run garbage collection in the same jiffy. Unfortunately, this is broken
when jiffies wrap around which this patch fixes.

The problem is that last_gc in the nf_conncount_list struct is an u32,
but jiffies is an unsigned long which is 8 bytes on my systems. When
those two are compared it only works until last_gc wraps around.

See bug report: https://bugzilla.netfilter.org/show_bug.cgi?id=1778
for more details.

Fixes: d265929930e2 ("netfilter: nf_conncount: reduce unnecessary GC")
Signed-off-by: Nicklas Bo Jensen <njensen@akamai.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/nf_conncount.c