]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: phy: fix save wrong speed and duplex problem if autoneg is on
authorGuangbin Huang <huangguangbin2@huawei.com>
Sat, 27 Feb 2021 03:05:58 +0000 (11:05 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Mar 2021 15:34:30 +0000 (16:34 +0100)
commit75593df99b8af54a2028e14da1584a5d748deec2
treecb1924dd4383c71c820ee8ced59af57ee03cb268
parentf197ef408f31db886cab97ad83a086210fd6db13
net: phy: fix save wrong speed and duplex problem if autoneg is on

[ Upstream commit d9032dba5a2b2bbf0fdce67c8795300ec9923b43 ]

If phy uses generic driver and autoneg is on, enter command
"ethtool -s eth0 speed 50" will not change phy speed actually, but
command "ethtool eth0" shows speed is 50Mb/s because phydev->speed
has been set to 50 and no update later.

And duplex setting has same problem too.

However, if autoneg is on, phy only changes speed and duplex according to
phydev->advertising, but not phydev->speed and phydev->duplex. So in this
case, phydev->speed and phydev->duplex don't need to be set in function
phy_ethtool_ksettings_set() if autoneg is on.

Fixes: 51e2a3846eab ("PHY: Avoid unnecessary aneg restarts")
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/phy/phy.c