]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: avoid signed overflows for SO_{SND|RCV}BUFFORCE
authorEric Dumazet <edumazet@google.com>
Fri, 2 Dec 2016 17:44:53 +0000 (09:44 -0800)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 23 Feb 2017 03:54:47 +0000 (03:54 +0000)
commit756826fd4e4a25589a2e77a7ceb791314c73cf48
tree4a2bd6c8d34521f3352677414cc2cb893c1268db
parent249741c2c0d7a905da66efc6d1292d3915aef1fc
net: avoid signed overflows for SO_{SND|RCV}BUFFORCE

commit b98b0bc8c431e3ceb4b26b0dfc8db509518fb290 upstream.

CAP_NET_ADMIN users should not be allowed to set negative
sk_sndbuf or sk_rcvbuf values, as it can lead to various memory
corruptions, crashes, OOM...

Note that before commit 82981930125a ("net: cleanups in
sock_setsockopt()"), the bug was even more serious, since SO_SNDBUF
and SO_RCVBUF were vulnerable.

This needs to be backported to all known linux kernels.

Again, many thanks to syzkaller team for discovering this gem.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/core/sock.c