]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Don't ignore dump image format errors
authorJim Fehlig <jfehlig@suse.com>
Thu, 20 Feb 2025 01:02:06 +0000 (18:02 -0700)
committerJim Fehlig <jfehlig@suse.com>
Mon, 3 Mar 2025 17:05:06 +0000 (10:05 -0700)
commit757fa62cfdeef5887ddce546561aed178f3bdbb1
treeea30ea6377188f8b961aa9cd3f0f7d9d84e130df
parent1a5692a6e15cac414f83caa2e120e949287b621a
qemu: Don't ignore dump image format errors

Long ago, without justification, commit 48cb9f0542 changed
qemuGetCompressionProgram (since renamed to
qemuSaveImageGetCompressionProgram) to ignore configuration errors
for dump operations. Like the other save-related operations, user
provided configuration should be verified and an error reported if
it cannot be honored.

Remove the special handling of configuration errors in
qemuSaveImageGetCompressionProgram and change the dump logic to
fail when dump image format cannot be supported.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
src/qemu/qemu_driver.c
src/qemu/qemu_saveimage.c
src/qemu/qemu_saveimage.h
src/qemu/qemu_snapshot.c