]> git.ipfire.org Git - thirdparty/linux.git/commit
intel-hid: fix volume buttons on Thinkpad X12 Detachable Tablet Gen 1
authorCole Stowell <cole@stowell.pro>
Thu, 7 Nov 2024 20:59:34 +0000 (20:59 +0000)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 12 Nov 2024 10:23:48 +0000 (12:23 +0200)
commit75a978bd604b5916d3e4430d4e6e5601162e14eb
tree7b6e545ab50acf8d52863e46a0e9990deada7fc8
parent0d5e2d9b8fcb58116df2a201c54af60c1ac50bf2
intel-hid: fix volume buttons on Thinkpad X12 Detachable Tablet Gen 1

Volume buttons on Lenovo Thinkpad X12 Detachable Tablet Gen 1 did not
send any input events when pressed. When loading intel-hid with the 5
Button Array explicitly enabled, the buttons functioned normally.

Adds the X12 Detachable Tablet Gen 1 to the `button_array_table`.

However, the driver is unable to call INTEL_HID_DSM_BTNE_FN and prints
the warning "failed to set button capability" when attempting to enable
or disable the 5 Button Array. The warning should be harmless and
adding more special handling to avoid it is not worth it.

Co-developed-by: Mary Strodl <mstrodl@csh.rit.edu>
Signed-off-by: Mary Strodl <mstrodl@csh.rit.edu>
Signed-off-by: Cole Stowell <cole@stowell.pro>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20241107205908.69279-1-cole@stowell.pro
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/intel/hid.c