]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
wifi: ath12k: fix incorrect logic of calculating vdev_stats_id
authorKang Yang <quic_kangyang@quicinc.com>
Mon, 5 Feb 2024 17:03:27 +0000 (19:03 +0200)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:27 +0000 (18:19 -0400)
commit75f1048672e796fbcbfdb58ad606060bc0858802
treec24e3db0706b03cccd4ccbc8217a1fb7210dd0ef
parent24648972fe5db2711ea9bbfac84c9420b7cc5021
wifi: ath12k: fix incorrect logic of calculating vdev_stats_id

[ Upstream commit 019b58dcb6ed267e17b7efd03ec8575c1b67d942 ]

During calculate vdev_stats_id, will compare vdev_stats_id with
ATH12K_INVAL_VDEV_STATS_ID by '<='. If vdev_stats_id is relatively
small, then assign ATH12K_INVAL_VDEV_STATS_ID to vdev_stats_id.

This logic is incorrect. Firstly, should use '>=' instead of '<=' to
check if this u8 variable exceeds the max valid range.

Secondly, should use the maximum value as comparison value.

Correct comparison symbols and use the maximum value
ATH12K_MAX_VDEV_STATS_ID for comparison.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/20240130040303.370590-3-quic_kangyang@quicinc.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/ath/ath12k/mac.c