]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/i915/frontbuffer: Move bo refcounting intel_frontbuffer_{get,release}()
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 3 Oct 2025 14:57:30 +0000 (17:57 +0300)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 13 Oct 2025 18:08:41 +0000 (14:08 -0400)
commit760039c95c78490c5c66ef584fcd536797ed6a2f
tree172f20386d3454dbe1dfe9dadd6b56d8d0b15f09
parent1696b0cfcf004a3af34ffe4c57a14e837ef18144
drm/i915/frontbuffer: Move bo refcounting intel_frontbuffer_{get,release}()

Currently xe's intel_frontbuffer implementation forgets to
hold a reference on the bo. This makes the entire thing
extremely fragile as the cleanup order now depends on bo
references held by other things
(namely intel_fb_bo_framebuffer_fini()).

Move the bo refcounting to intel_frontbuffer_{get,release}()
so that both i915 and xe do this the same way.

I first tried to fix this by having xe do the refcounting
from its intel_bo_set_frontbuffer() implementation
(which is what i915 does currently), but turns out xe's
drm_gem_object_free() can sleep and thus drm_gem_object_put()
isn't safe to call while we hold fb_tracking.lock.

Fixes: 10690b8a49bc ("drm/i915/display: Add intel_fb_bo_framebuffer_fini")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20251003145734.7634-2-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
(cherry picked from commit eb4d490729a5fd8dc5a76d334f8d01fec7c14bbe)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/display/intel_frontbuffer.c
drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.h