]> git.ipfire.org Git - thirdparty/kea.git/commit
[5556a] Addressed review comments
authorThomas Markwalder <tmark@isc.org>
Mon, 9 Apr 2018 18:42:42 +0000 (14:42 -0400)
committerThomas Markwalder <tmark@isc.org>
Mon, 9 Apr 2018 18:42:42 +0000 (14:42 -0400)
commit76ddd1ffdd5ee858b3dfdad3e58fed8e3e105b26
tree9f2a00c6f71af66c6a2b2f36ceb879e5782876a2
parent5cf5d9c90838082166f13deaa45acefd5bc79f81
[5556a] Addressed review comments

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
    LeaseMgrDbLostCallbackTest::testNoCallbackOnOpenFailure() {
    - removed before hand checks for socket descriptor, grab
    the most recently opend descriptor after connecting to the db
    and assume its the SQL client's

    - test return value of close() rather then errno

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.h
    LeaseMgrDbLostCallbackTest
    - constructor and destructor clear
    DatabaseConnection::db_lost_callback

src/lib/dhcpsrv/tests/host_mgr_unittest.cc
    HostMgrDbLostCallbackTest
    - Setup and Teardown methods clear DatabaseConnection::db_lost_callback

    HostMgrDbLostCallbackTest::testDbLostCallback()
    - removed before hand checks for socket descriptor, grab
    the most recently opend descriptor after connecting to the db
    and assume its the SQL client's

    - test return value of close() rather then errno

src/lib/dhcpsrv/tests/test_utils.cc
    int findLastSocketFd()
    - iterate over all descriptors rather than stopping at first invalid
src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.h
src/lib/dhcpsrv/tests/host_mgr_unittest.cc
src/lib/dhcpsrv/tests/test_utils.cc