]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
MIPS: VPE: Fix a double free and a memory leak in 'release_vpe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 2 Feb 2020 20:19:22 +0000 (21:19 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Mar 2020 15:45:18 +0000 (16:45 +0100)
commit7700ea8e6f68dbc44161758f2ad3b64ece920cf0
tree47233962c5648639039ecb4839f5fa34655c4353
parentb41d6924d34d6003e9e2f040f6f80c3ee0e1b155
MIPS: VPE: Fix a double free and a memory leak in 'release_vpe()'

commit bef8e2dfceed6daeb6ca3e8d33f9c9d43b926580 upstream.

Pointer on the memory allocated by 'alloc_progmem()' is stored in
'v->load_addr'. So this is this memory that should be freed by
'release_progmem()'.

'release_progmem()' is only a call to 'kfree()'.

With the current code, there is both a double free and a memory leak.
Fix it by passing the correct pointer to 'release_progmem()'.

Fixes: e01402b115ccc ("More AP / SP bits for the 34K, the Malta bits and things. Still wants")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Paul Burton <paulburton@kernel.org>
Cc: ralf@linux-mips.org
Cc: linux-mips@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/mips/kernel/vpe.c