]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
USB: serial: digi_acceleport: fix OOB data sanity check
authorJohan Hovold <johan@kernel.org>
Tue, 31 Jan 2017 16:17:27 +0000 (17:17 +0100)
committerJiri Slaby <jslaby@suse.cz>
Tue, 28 Mar 2017 13:49:04 +0000 (15:49 +0200)
commit771046c521c67a00d9b97896317dbe0f301b3edc
tree24caebbfdd1c16a17ce8f8cd7745eff3319962cc
parentaa11eaeb2eb9f7ba81b1cbbf0f7394c2abf3b659
USB: serial: digi_acceleport: fix OOB data sanity check

commit 2d380889215fe20b8523345649dee0579821800c upstream.

Make sure to check for short transfers to avoid underflow in a loop
condition when parsing the receive buffer.

Also fix an off-by-one error in the incomplete sanity check which could
lead to invalid data being parsed.

Fixes: 8c209e6782ca ("USB: make actual_length in struct urb field u32")
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/usb/serial/digi_acceleport.c