]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
inetdevice: fixed signed integer overflow
authorVincent BENAYOUN <vincent.benayoun@trust-in-soft.com>
Thu, 13 Nov 2014 12:47:26 +0000 (13:47 +0100)
committerJiri Slaby <jslaby@suse.cz>
Thu, 27 Nov 2014 10:14:05 +0000 (11:14 +0100)
commit77256f4afd82ebda1bd5564709809bae22b58f41
tree6403f18f03903f8181c6aa8d34496f68b80e0e14
parent0bdeed7d131bf61214dbce110959925c13ac7be5
inetdevice: fixed signed integer overflow

[ Upstream commit 84bc88688e3f6ef843aa8803dbcd90168bb89faf ]

There could be a signed overflow in the following code.

The expression, (32-logmask) is comprised between 0 and 31 included.
It may be equal to 31.
In such a case the left shift will produce a signed integer overflow.
According to the C99 Standard, this is an undefined behavior.
A simple fix is to replace the signed int 1 with the unsigned int 1U.

Signed-off-by: Vincent BENAYOUN <vincent.benayoun@trust-in-soft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
include/linux/inetdevice.h