]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
serial: stm32: fix clearing interrupt error flags
authorFabrice Gasnier <fabrice.gasnier@st.com>
Thu, 21 Nov 2019 08:10:49 +0000 (09:10 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 13 Dec 2019 07:48:23 +0000 (08:48 +0100)
commit778a1d195d76e04cfb5ad5e1a522e5773c4b877a
treefabc5d215ffe14e57b714907d715ee70cf6d88e8
parent365da5d0b18089a7950e4fec283adbd968c8bfe8
serial: stm32: fix clearing interrupt error flags

commit 1250ed7114a977cdc2a67a0c09d6cdda63970eb9 upstream.

The interrupt clear flag register is a "write 1 to clear" register.
So, only writing ones allows to clear flags:
- Replace buggy stm32_clr_bits() by a simple write to clear error flags
- Replace useless read/modify/write stm32_set_bits() routine by a
  simple write to clear TC (transfer complete) flag.

Fixes: 4f01d833fdcd ("serial: stm32: fix rx error handling")
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/1574323849-1909-1-git-send-email-fabrice.gasnier@st.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/stm32-usart.c