]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
batman-adv: Don't accept TT entries for out-of-spec VIDs
authorSven Eckelmann <sven@narfation.org>
Sat, 4 May 2024 19:57:30 +0000 (21:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Jul 2024 07:31:58 +0000 (09:31 +0200)
commit778a8e67c7418b0ed41d059726bc8d8036e7b67c
tree4b8c3f0c458d3ce54dc39931c82a1db2f92abe6d
parentc92a15b3b2964e2f04e4423fcef85f94f03ddda7
batman-adv: Don't accept TT entries for out-of-spec VIDs

commit 537a350d14321c8cca5efbf0a33a404fec3a9f9e upstream.

The internal handling of VLAN IDs in batman-adv is only specified for
following encodings:

* VLAN is used
  - bit 15 is 1
  - bit 11 - bit 0 is the VLAN ID (0-4095)
  - remaining bits are 0
* No VLAN is used
  - bit 15 is 0
  - remaining bits are 0

batman-adv was only preparing new translation table entries (based on its
soft interface information) using this encoding format. But the receive
path was never checking if entries in the roam or TT TVLVs were also
following this encoding.

It was therefore possible to create more than the expected maximum of 4096
+ 1 entries in the originator VLAN list. Simply by setting the "remaining
bits" to "random" values in corresponding TVLV.

Cc: stable@vger.kernel.org
Fixes: 7ea7b4a14275 ("batman-adv: make the TT CRC logic VLAN specific")
Reported-by: Linus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/batman-adv/originator.c